Skip to content

Commit

Permalink
net: calxedaxgmac: remove explicit rx dma buffer polling
Browse files Browse the repository at this point in the history
New received frames will trigger the rx DMA to poll the DMA descriptors,
so there is no need to tell the h/w to poll. We also want to enable
dropping frames from the fifo when there is no buffer.

Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Rob Herring authored and David S. Miller committed Nov 7, 2012
1 parent 0aefa8e commit b821bd8
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/net/ethernet/calxeda/xgmac.c
Original file line number Diff line number Diff line change
Expand Up @@ -966,7 +966,7 @@ static int xgmac_hw_init(struct net_device *dev)
ctrl |= XGMAC_CONTROL_IPC;
writel(ctrl, ioaddr + XGMAC_CONTROL);

writel(DMA_CONTROL_DFF | DMA_CONTROL_OSF, ioaddr + XGMAC_DMA_CONTROL);
writel(DMA_CONTROL_OSF, ioaddr + XGMAC_DMA_CONTROL);

/* Set the HW DMA mode and the COE */
writel(XGMAC_OMR_TSF | XGMAC_OMR_RFD | XGMAC_OMR_RFA |
Expand Down Expand Up @@ -1180,8 +1180,6 @@ static int xgmac_rx(struct xgmac_priv *priv, int limit)

xgmac_rx_refill(priv);

writel(1, priv->base + XGMAC_DMA_RX_POLL);

return count;
}

Expand Down

0 comments on commit b821bd8

Please sign in to comment.