Skip to content

Commit

Permalink
drm/omap: remove warn from debugfs
Browse files Browse the repository at this point in the history
Patch dfe96dd (omapdrm: simplify locking in
the fb debugfs file) removed taking locks when using omapdrm's debugfs
to dump fb objects.

However, in omap_gem_describe we give a WARN is the lock has not been
taken, so that WARN is now seen every time omapdrm debugfs is used.

So, presuming the removal of locks is ok, we can also remove the WARN.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
  • Loading branch information
Tomi Valkeinen committed Apr 15, 2014
1 parent 772cdc9 commit b841aed
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/gpu/drm/omapdrm/omap_gem.c
Original file line number Diff line number Diff line change
Expand Up @@ -980,12 +980,9 @@ int omap_gem_resume(struct device *dev)
#ifdef CONFIG_DEBUG_FS
void omap_gem_describe(struct drm_gem_object *obj, struct seq_file *m)
{
struct drm_device *dev = obj->dev;
struct omap_gem_object *omap_obj = to_omap_bo(obj);
uint64_t off;

WARN_ON(!mutex_is_locked(&dev->struct_mutex));

off = drm_vma_node_start(&obj->vma_node);

seq_printf(m, "%08x: %2d (%2d) %08llx %08Zx (%2d) %p %4d",
Expand Down

0 comments on commit b841aed

Please sign in to comment.