Skip to content

Commit

Permalink
gianfar: fix bug caused by 87c288c
Browse files Browse the repository at this point in the history
commit 87c288c "gianfar: do vlan cleanup" has two issues:
# permutation of rx and tx flags
# enabling vlan tag insertion by default (this leads to unusable connections on some configurations)

If VLAN insertion is requested (via ethtool) it will be set at an other point ...

Signed-off-by: Sebastian Poehn <sebastian.poehn@belden.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Sebastian Pöhn authored and David S. Miller committed Jul 28, 2011
1 parent b49179c commit b852b72
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions drivers/net/gianfar.c
Original file line number Diff line number Diff line change
Expand Up @@ -388,12 +388,8 @@ static void gfar_init_mac(struct net_device *ndev)
if (priv->hwts_rx_en)
rctrl |= RCTRL_PRSDEP_INIT | RCTRL_TS_ENABLE;

/* keep vlan related bits if it's enabled */
if (ndev->features & NETIF_F_HW_VLAN_TX)
rctrl |= RCTRL_VLEX | RCTRL_PRSDEP_INIT;

if (ndev->features & NETIF_F_HW_VLAN_RX)
tctrl |= TCTRL_VLINS;
rctrl |= RCTRL_VLEX | RCTRL_PRSDEP_INIT;

/* Init rctrl based on our settings */
gfar_write(&regs->rctrl, rctrl);
Expand Down

0 comments on commit b852b72

Please sign in to comment.