Skip to content

Commit

Permalink
staging: comedi: refactor dt2815 driver to remove forward declarations
Browse files Browse the repository at this point in the history
Move the module_init/module_exit routines and the associated
struct comedi_driver and other variables to the end of the source.
This is more typical of how other drivers are written and removes
the need for the forward declarations.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Apr 30, 2012
1 parent 37859f8 commit b85eec9
Showing 1 changed file with 19 additions and 25 deletions.
44 changes: 19 additions & 25 deletions drivers/staging/comedi/drivers/dt2815.c
Original file line number Diff line number Diff line change
Expand Up @@ -72,31 +72,6 @@ static const struct comedi_lrange
#define DT2815_DATA 0
#define DT2815_STATUS 1

static int dt2815_attach(struct comedi_device *dev,
struct comedi_devconfig *it);
static int dt2815_detach(struct comedi_device *dev);
static struct comedi_driver driver_dt2815 = {
.driver_name = "dt2815",
.module = THIS_MODULE,
.attach = dt2815_attach,
.detach = dt2815_detach,
};

static int __init driver_dt2815_init_module(void)
{
return comedi_driver_register(&driver_dt2815);
}

static void __exit driver_dt2815_cleanup_module(void)
{
comedi_driver_unregister(&driver_dt2815);
}

module_init(driver_dt2815_init_module);
module_exit(driver_dt2815_cleanup_module);

static void dt2815_free_resources(struct comedi_device *dev);

struct dt2815_private {

const struct comedi_lrange *range_type_list[8];
Expand Down Expand Up @@ -267,6 +242,25 @@ static int dt2815_detach(struct comedi_device *dev)
return 0;
}

static struct comedi_driver driver_dt2815 = {
.driver_name = "dt2815",
.module = THIS_MODULE,
.attach = dt2815_attach,
.detach = dt2815_detach,
};

static int __init driver_dt2815_init_module(void)
{
return comedi_driver_register(&driver_dt2815);
}
module_init(driver_dt2815_init_module);

static void __exit driver_dt2815_cleanup_module(void)
{
comedi_driver_unregister(&driver_dt2815);
}
module_exit(driver_dt2815_cleanup_module);

MODULE_AUTHOR("Comedi http://www.comedi.org");
MODULE_DESCRIPTION("Comedi low-level driver");
MODULE_LICENSE("GPL");

0 comments on commit b85eec9

Please sign in to comment.