Skip to content

Commit

Permalink
staging: comedi: ni_daq_700: change the 'attach' printk's to dev_prin…
Browse files Browse the repository at this point in the history
…tk's

Use the dev_printk() routines to output the kernel messages in the
attach routine.

The main 'attach' message had a level of KERN_ERR, I believe it should
have been KERN_INFO. Also, move that message to the end of the attach
so it only gets displayed if the attach is successful.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Jun 23, 2012
1 parent 40cfdb9 commit b88c599
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions drivers/staging/comedi/drivers/ni_daq_700.c
Original file line number Diff line number Diff line change
Expand Up @@ -113,11 +113,8 @@ static int dio700_attach(struct comedi_device *dev, struct comedi_devconfig *it)
return -EIO;
iobase = link->resource[0]->start;

printk(KERN_ERR "comedi%d: ni_daq_700: %s, io 0x%lx\n", dev->minor,
thisboard->name, iobase);

if (iobase == 0) {
printk(KERN_ERR "io base address is zero!\n");
dev_err(dev->class_dev, "io base address is zero!\n");
return -EINVAL;
}

Expand All @@ -142,6 +139,11 @@ static int dio700_attach(struct comedi_device *dev, struct comedi_devconfig *it)
s->state = 0;
s->io_bits = 0x00ff;

dev_info(dev->class_dev, "%s: %s, io 0x%lx\n",
dev->driver->driver_name,
dev->board_name,
dev->iobase);

return 0;
};

Expand Down

0 comments on commit b88c599

Please sign in to comment.