Skip to content

Commit

Permalink
ion: change ion_user_handle_t definition to int
Browse files Browse the repository at this point in the history
Turn ion_user_handle_t to int. This change reflects the underlying type
returned by the ion driver.

Signed-off-by: Rom Lemarchand <romlem@google.com>
[jstultz: modified patch to apply to staging directory]
Signed-off-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Rom Lemarchand authored and Greg Kroah-Hartman committed Dec 14, 2013
1 parent 22b7f24 commit b88fa73
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions drivers/staging/android/ion/ion.c
Original file line number Diff line number Diff line change
Expand Up @@ -1139,7 +1139,7 @@ static long ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
if (IS_ERR(handle))
return PTR_ERR(handle);

data.handle = (ion_user_handle_t)handle->id;
data.handle = handle->id;

if (copy_to_user((void __user *)arg, &data, sizeof(data))) {
ion_free(client, handle);
Expand All @@ -1156,7 +1156,7 @@ static long ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
sizeof(struct ion_handle_data)))
return -EFAULT;
mutex_lock(&client->lock);
handle = ion_uhandle_get(client, (int)data.handle);
handle = ion_uhandle_get(client, data.handle);
mutex_unlock(&client->lock);
if (!handle)
return -EINVAL;
Expand All @@ -1171,7 +1171,7 @@ static long ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)

if (copy_from_user(&data, (void __user *)arg, sizeof(data)))
return -EFAULT;
handle = ion_uhandle_get(client, (int)data.handle);
handle = ion_uhandle_get(client, data.handle);
data.fd = ion_share_dma_buf_fd(client, handle);
if (copy_to_user((void __user *)arg, &data, sizeof(data)))
return -EFAULT;
Expand All @@ -1191,7 +1191,7 @@ static long ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
if (IS_ERR(handle))
ret = PTR_ERR(handle);
else
data.handle = (ion_user_handle_t)handle->id;
data.handle = handle->id;

if (copy_to_user((void __user *)arg, &data,
sizeof(struct ion_fd_data)))
Expand Down
4 changes: 2 additions & 2 deletions drivers/staging/android/ion/ion.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@

#include <linux/types.h>

struct ion_handle;
typedef struct ion_handle *ion_user_handle_t;
typedef int ion_user_handle_t;

/**
* enum ion_heap_types - list of all possible types of heaps
Expand Down Expand Up @@ -65,6 +64,7 @@ enum ion_heap_type {
caches must be managed manually */

#ifdef __KERNEL__
struct ion_handle;
struct ion_device;
struct ion_heap;
struct ion_mapper;
Expand Down

0 comments on commit b88fa73

Please sign in to comment.