Skip to content

Commit

Permalink
fix return values of l2tp_dfs_seq_open()
Browse files Browse the repository at this point in the history
More fallout from struct net lifetime rules review: PTR_ERR() is *already*
negative and failing ->open() should return negatives on failure.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: James Chapman <jchapman@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Al Viro authored and David S. Miller committed Jun 5, 2011
1 parent c316e6a commit b8f07a0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/l2tp/l2tp_debugfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ static int l2tp_dfs_seq_open(struct inode *inode, struct file *file)
*/
pd->net = get_net_ns_by_pid(current->pid);
if (IS_ERR(pd->net)) {
rc = -PTR_ERR(pd->net);
rc = PTR_ERR(pd->net);
goto err_free_pd;
}

Expand Down

0 comments on commit b8f07a0

Please sign in to comment.