Skip to content

Commit

Permalink
pxafb: convert ctrlr_sem in a mutex
Browse files Browse the repository at this point in the history
The semaphore ctrlr_sem is used as a mutex.  Convert it to the mutex API.

Signed-off-by: Matthias Kaehlcke <matthias@kaehlcke.net>
Cc: Daniel Mack <daniel@caiaq.de>
Cc: Eric Miao <eric.miao@marvell.com>
Cc: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Matthias Kaehlcke authored and Linus Torvalds committed Jul 24, 2008
1 parent 14aefd1 commit b91dbce
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
7 changes: 4 additions & 3 deletions drivers/video/pxafb.c
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
#include <linux/clk.h>
#include <linux/err.h>
#include <linux/completion.h>
#include <linux/mutex.h>
#include <linux/kthread.h>
#include <linux/freezer.h>

Expand Down Expand Up @@ -1117,7 +1118,7 @@ static void set_ctrlr_state(struct pxafb_info *fbi, u_int state)
{
u_int old_state;

down(&fbi->ctrlr_sem);
mutex_lock(&fbi->ctrlr_lock);

old_state = fbi->state;

Expand Down Expand Up @@ -1205,7 +1206,7 @@ static void set_ctrlr_state(struct pxafb_info *fbi, u_int state)
}
break;
}
up(&fbi->ctrlr_sem);
mutex_unlock(&fbi->ctrlr_lock);
}

/*
Expand Down Expand Up @@ -1458,7 +1459,7 @@ static struct pxafb_info * __devinit pxafb_init_fbinfo(struct device *dev)

init_waitqueue_head(&fbi->ctrlr_wait);
INIT_WORK(&fbi->task, pxafb_task);
init_MUTEX(&fbi->ctrlr_sem);
mutex_init(&fbi->ctrlr_lock);
init_completion(&fbi->disable_done);
#ifdef CONFIG_FB_PXA_SMARTPANEL
init_completion(&fbi->command_done);
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/pxafb.h
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ struct pxafb_info {

volatile u_char state;
volatile u_char task_state;
struct semaphore ctrlr_sem;
struct mutex ctrlr_lock;
wait_queue_head_t ctrlr_wait;
struct work_struct task;

Expand Down

0 comments on commit b91dbce

Please sign in to comment.