Skip to content

Commit

Permalink
gigaset: include cleanup cleanup
Browse files Browse the repository at this point in the history
Commit 5a0e3ad causes slab.h to be included twice in many of the
Gigaset driver's source files, first via the common include file
gigaset.h and then a second time directly. Drop the spares, and
use the opportunity to clean up a few more similar cases.

Impact: cleanup, no functional change
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
CC: Tejun Heo <tj@kernel.org>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Tilman Schmidt authored and David S. Miller committed Apr 18, 2010
1 parent 1c4f019 commit b91ecb0
Show file tree
Hide file tree
Showing 9 changed files with 1 addition and 20 deletions.
5 changes: 0 additions & 5 deletions drivers/isdn/gigaset/bas-gigaset.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,6 @@
*/

#include "gigaset.h"

#include <linux/errno.h>
#include <linux/init.h>
#include <linux/slab.h>
#include <linux/timer.h>
#include <linux/usb.h>
#include <linux/module.h>
#include <linux/moduleparam.h>
Expand Down
2 changes: 0 additions & 2 deletions drivers/isdn/gigaset/capi.c
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
*/

#include "gigaset.h"
#include <linux/slab.h>
#include <linux/ctype.h>
#include <linux/proc_fs.h>
#include <linux/seq_file.h>
#include <linux/isdn/capilli.h>
Expand Down
2 changes: 0 additions & 2 deletions drivers/isdn/gigaset/common.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,8 @@
*/

#include "gigaset.h"
#include <linux/ctype.h>
#include <linux/module.h>
#include <linux/moduleparam.h>
#include <linux/slab.h>

/* Version Information */
#define DRIVER_AUTHOR "Hansjoerg Lipp <hjlipp@web.de>, Tilman Schmidt <tilman@imap.cc>, Stefan Eilers"
Expand Down
2 changes: 1 addition & 1 deletion drivers/isdn/gigaset/gigaset.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@
#include <linux/kernel.h>
#include <linux/compiler.h>
#include <linux/types.h>
#include <linux/ctype.h>
#include <linux/slab.h>
#include <linux/spinlock.h>
#include <linux/usb.h>
#include <linux/skbuff.h>
#include <linux/netdevice.h>
#include <linux/ppp_defs.h>
Expand Down
1 change: 0 additions & 1 deletion drivers/isdn/gigaset/i4l.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@

#include "gigaset.h"
#include <linux/isdnif.h>
#include <linux/slab.h>

#define HW_HDR_LEN 2 /* Header size used to store ack info */

Expand Down
1 change: 0 additions & 1 deletion drivers/isdn/gigaset/interface.c
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

#include "gigaset.h"
#include <linux/gigaset_dev.h>
#include <linux/tty.h>
#include <linux/tty_flip.h>

/*** our ioctls ***/
Expand Down
1 change: 0 additions & 1 deletion drivers/isdn/gigaset/proc.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
*/

#include "gigaset.h"
#include <linux/ctype.h>

static ssize_t show_cidmode(struct device *dev,
struct device_attribute *attr, char *buf)
Expand Down
3 changes: 0 additions & 3 deletions drivers/isdn/gigaset/ser-gigaset.c
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,10 @@
*/

#include "gigaset.h"

#include <linux/module.h>
#include <linux/moduleparam.h>
#include <linux/platform_device.h>
#include <linux/tty.h>
#include <linux/completion.h>
#include <linux/slab.h>

/* Version Information */
#define DRIVER_AUTHOR "Tilman Schmidt"
Expand Down
4 changes: 0 additions & 4 deletions drivers/isdn/gigaset/usb-gigaset.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@
*/

#include "gigaset.h"

#include <linux/errno.h>
#include <linux/init.h>
#include <linux/slab.h>
#include <linux/usb.h>
#include <linux/module.h>
#include <linux/moduleparam.h>
Expand Down

0 comments on commit b91ecb0

Please sign in to comment.