Skip to content

Commit

Permalink
staging: brcm80211: removed global function declarations from .c files
Browse files Browse the repository at this point in the history
Code cleanup. Function declarations were moved to .h files.

Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Roland Vossen authored and Greg Kroah-Hartman committed Jul 5, 2011
1 parent fb1d0aa commit b9a7429
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 26 deletions.
6 changes: 0 additions & 6 deletions drivers/staging/brcm80211/brcmfmac/bcmsdh_linux.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@
#include <brcmu_wifi.h>
#include "sdio_host.h"

extern void brcmf_sdbrcm_isr(void *args);

#include "dngl_stats.h"
#include "dhd.h"
#include "dhd_bus.h"
Expand Down Expand Up @@ -195,8 +193,6 @@ int brcmf_sdio_remove(struct device *dev)
return 0;
}

extern int brcmf_sdio_function_init(void);

int brcmf_sdio_register(struct brcmf_sdioh_driver *driver)
{
drvinfo = *driver;
Expand All @@ -205,8 +201,6 @@ int brcmf_sdio_register(struct brcmf_sdioh_driver *driver)
return brcmf_sdio_function_init();
}

extern void brcmf_sdio_function_cleanup(void);

void brcmf_sdio_unregister(void)
{
brcmf_sdio_function_cleanup();
Expand Down
9 changes: 3 additions & 6 deletions drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,9 @@
#include "dhd.h"
#include "bcmsdh_sdmmc.h"

extern int brcmf_sdio_function_init(void);
extern void brcmf_sdio_function_cleanup(void);

static void brcmf_sdioh_irqhandler(struct sdio_func *func);
static void brcmf_sdioh_irqhandler_f2(struct sdio_func *func);
static int brcmf_sdioh_get_cisaddr(struct sdioh_info *sd, u32 regaddr);
extern int brcmf_sdioh_reset_comm(struct mmc_card *card);

uint sd_f2_blocksize = 512; /* Default blocksize */

Expand All @@ -50,8 +46,9 @@ BRCMF_PM_RESUME_WAIT_INIT(sdioh_request_buffer_wait);

#define DMA_ALIGN_MASK 0x03

int brcmf_sdioh_card_regread(struct sdioh_info *sd, int func, u32 regaddr,
int regsize, u32 *data);
static int
brcmf_sdioh_card_regread(struct sdioh_info *sd, int func, u32 regaddr,
int regsize, u32 *data);

static int brcmf_sdioh_enablefuncs(struct sdioh_info *sd)
{
Expand Down
10 changes: 5 additions & 5 deletions drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.h
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,6 @@
#define sd_ctrl(x)
#endif

/* Allocate/init/free per-OS private data */
extern int brcmf_sdioh_osinit(struct sdioh_info *sd);
extern void brcmf_sdioh_osfree(struct sdioh_info *sd);

#define BLOCK_SIZE_64 64
#define BLOCK_SIZE_512 512
#define BLOCK_SIZE_4318 64
Expand Down Expand Up @@ -108,6 +104,10 @@ struct sdioh_info {
/* Global message bits */
extern uint sd_msglevel;

/* Allocate/init/free per-OS private data */
extern int brcmf_sdioh_osinit(struct sdioh_info *sd);
extern void brcmf_sdioh_osfree(struct sdioh_info *sd);

/* OS-independent interrupt handler */
extern bool brcmf_sdioh_check_client_intr(struct sdioh_info *sd);

Expand All @@ -124,7 +124,7 @@ extern u32 *brcmf_sdioh_reg_map(s32 addr, int size);
extern void brcmf_sdioh_reg_unmap(s32 addr, int size);

/* Interrupt (de)registration routines */
extern int brcmf_sdioh_register_irq(struct sdioh_info *sd, uint irq);
extern int brcmf_sdioh_register_irq(struct sdioh_info *sd, uint irq);
extern void brcmf_sdioh_free_irq(uint irq, struct sdioh_info *sd);

typedef struct _BCMSDH_SDMMC_INSTANCE {
Expand Down
8 changes: 0 additions & 8 deletions drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc_linux.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,6 @@
#include "dhd_dbg.h"
#include "wl_cfg80211.h"

extern void brcmf_sdioh_dev_intr_off(struct sdioh_info *sd);
extern void brcmf_sdioh_dev_intr_on(struct sdioh_info *sd);

int brcmf_sdio_function_init(void);
void brcmf_sdio_function_cleanup(void);

/* module param defaults */
static int clockoverride;

Expand All @@ -72,8 +66,6 @@ PBCMSDH_SDMMC_INSTANCE gInstance;
/* Maximum number of bcmsdh_sdmmc devices supported by driver */
#define BCMSDH_SDMMC_MAX_DEVICES 1

extern int brcmf_sdio_probe(struct device *dev);
extern int brcmf_sdio_remove(struct device *dev);
struct device sdmmc_dev;

static int brcmf_ops_sdio_probe(struct sdio_func *func,
Expand Down
1 change: 0 additions & 1 deletion drivers/staging/brcm80211/brcmfmac/dhd_cdc.c
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,6 @@ int brcmf_proto_cdc_set_ioctl(struct brcmf_pub *dhd, int ifidx, uint cmd,
return ret;
}

extern int dhd_bus_interface(struct dhd_bus *bus, uint arg, void *arg2);
int
brcmf_proto_ioctl(struct brcmf_pub *dhd, int ifidx, struct brcmf_ioctl *ioc,
void *buf, int len)
Expand Down
9 changes: 9 additions & 0 deletions drivers/staging/brcm80211/brcmfmac/sdio_host.h
Original file line number Diff line number Diff line change
Expand Up @@ -209,11 +209,20 @@ struct brcmf_sdioh_driver {
void (*detach) (void *ch);
};

struct sdioh_info;

/* platform specific/high level functions */
extern int brcmf_sdio_function_init(void);
extern int brcmf_sdio_register(struct brcmf_sdioh_driver *driver);
extern void brcmf_sdio_unregister(void);
extern bool brcmf_sdio_chipmatch(u16 vendor, u16 device);
extern void brcmf_sdio_device_remove(void *sdh);
extern void brcmf_sdio_function_cleanup(void);

extern void brcmf_sdioh_dev_intr_off(struct sdioh_info *sd);
extern void brcmf_sdioh_dev_intr_on(struct sdioh_info *sd);
extern int brcmf_sdio_probe(struct device *dev);
extern int brcmf_sdio_remove(struct device *dev);

/* Function to pass device-status bits to DHD. */
extern u32 brcmf_sdcard_get_dstatus(void *sdh);
Expand Down

0 comments on commit b9a7429

Please sign in to comment.