Skip to content

Commit

Permalink
sfc: Remove early call to efx_nic_type::reconfigure_mac in efx_reset_…
Browse files Browse the repository at this point in the history
…up()

efx_reset_up() calls efx_nic_type::reconfigure_mac once directly,
then again through efx_start_all() -> efx_start_port() ->
efx->type->reconfigure_mac().

This first call is also made too early to work properly on EF10.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
  • Loading branch information
Ben Hutchings committed Aug 27, 2013
1 parent d36a08b commit ba388fd
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/net/ethernet/sfc/efx.c
Original file line number Diff line number Diff line change
Expand Up @@ -2202,8 +2202,6 @@ int efx_reset_up(struct efx_nic *efx, enum reset_type method, bool ok)
"could not restore PHY settings\n");
}

efx->type->reconfigure_mac(efx);

efx_enable_interrupts(efx);
efx_restore_filters(efx);
efx_sriov_reset(efx);
Expand Down

0 comments on commit ba388fd

Please sign in to comment.