Skip to content

Commit

Permalink
userns: Convert isofs to use kuid/kgid where appropriate
Browse files Browse the repository at this point in the history
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
  • Loading branch information
Eric W. Biederman committed Sep 21, 2012
1 parent 16525e3 commit ba64e2b
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 11 deletions.
17 changes: 11 additions & 6 deletions fs/isofs/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
#include <linux/cdrom.h>
#include <linux/parser.h>
#include <linux/mpage.h>
#include <linux/user_namespace.h>

#include "isofs.h"
#include "zisofs.h"
Expand Down Expand Up @@ -171,8 +172,8 @@ struct iso9660_options{
unsigned int blocksize;
umode_t fmode;
umode_t dmode;
gid_t gid;
uid_t uid;
kgid_t gid;
kuid_t uid;
char *iocharset;
/* LVE */
s32 session;
Expand Down Expand Up @@ -383,8 +384,8 @@ static int parse_options(char *options, struct iso9660_options *popt)
popt->fmode = popt->dmode = ISOFS_INVALID_MODE;
popt->uid_set = 0;
popt->gid_set = 0;
popt->gid = 0;
popt->uid = 0;
popt->gid = GLOBAL_ROOT_GID;
popt->uid = GLOBAL_ROOT_UID;
popt->iocharset = NULL;
popt->utf8 = 0;
popt->overriderockperm = 0;
Expand Down Expand Up @@ -460,13 +461,17 @@ static int parse_options(char *options, struct iso9660_options *popt)
case Opt_uid:
if (match_int(&args[0], &option))
return 0;
popt->uid = option;
popt->uid = make_kuid(current_user_ns(), option);
if (!uid_valid(popt->uid))
return 0;
popt->uid_set = 1;
break;
case Opt_gid:
if (match_int(&args[0], &option))
return 0;
popt->gid = option;
popt->gid = make_kgid(current_user_ns(), option);
if (!gid_valid(popt->gid))
return 0;
popt->gid_set = 1;
break;
case Opt_mode:
Expand Down
4 changes: 2 additions & 2 deletions fs/isofs/isofs.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ struct isofs_sb_info {

umode_t s_fmode;
umode_t s_dmode;
gid_t s_gid;
uid_t s_uid;
kgid_t s_gid;
kuid_t s_uid;
struct nls_table *s_nls_iocharset; /* Native language support table */
};

Expand Down
4 changes: 2 additions & 2 deletions fs/isofs/rock.c
Original file line number Diff line number Diff line change
Expand Up @@ -364,8 +364,8 @@ parse_rock_ridge_inode_internal(struct iso_directory_record *de,
case SIG('P', 'X'):
inode->i_mode = isonum_733(rr->u.PX.mode);
set_nlink(inode, isonum_733(rr->u.PX.n_links));
inode->i_uid = isonum_733(rr->u.PX.uid);
inode->i_gid = isonum_733(rr->u.PX.gid);
i_uid_write(inode, isonum_733(rr->u.PX.uid));
i_gid_write(inode, isonum_733(rr->u.PX.gid));
break;
case SIG('P', 'N'):
{
Expand Down
1 change: 0 additions & 1 deletion init/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -944,7 +944,6 @@ config UIDGID_CONVERTED
depends on FUSE_FS = n
depends on GFS2_FS = n
depends on HPFS_FS = n
depends on ISO9660_FS = n
depends on JFFS2_FS = n
depends on JFS_FS = n
depends on LOGFS = n
Expand Down

0 comments on commit ba64e2b

Please sign in to comment.