Skip to content

Commit

Permalink
USB: Serial: garmin_gps.c: remove debug module parameter
Browse files Browse the repository at this point in the history
Now that all usb-serial modules are only using dev_dbg()
the debug module parameter does not do anything at all, so
remove it to reduce any confusion if someone were to try to
use it.

CC: Johan Hovold <jhovold@gmail.com>
CC: Rusty Russell <rusty@rustcorp.com.au>
CC: Alan Stern <stern@rowland.harvard.edu>
CC: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Greg Kroah-Hartman committed Sep 18, 2012
1 parent 9d27b6a commit ba74b89
Showing 1 changed file with 0 additions and 14 deletions.
14 changes: 0 additions & 14 deletions drivers/usb/serial/garmin_gps.c
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,6 @@
/* the mode to be set when the port ist opened */
static int initial_mode = 1;

/* debug flag */
static bool debug;

#define GARMIN_VENDOR_ID 0x091E

/*
Expand Down Expand Up @@ -1108,15 +1105,6 @@ static int garmin_write(struct tty_struct *tty, struct usb_serial_port *port,
garmin_clear(garmin_data_p);

switch (pktid) {

case PRIV_PKTID_SET_DEBUG:
if (pktsiz != 4)
return -EINVPKT;
debug = __le32_to_cpu(privpkt[3]);
dev_dbg(dev, "%s - debug level set to 0x%X\n",
__func__, debug);
break;

case PRIV_PKTID_SET_MODE:
if (pktsiz != 4)
return -EINVPKT;
Expand Down Expand Up @@ -1498,7 +1486,5 @@ MODULE_AUTHOR(DRIVER_AUTHOR);
MODULE_DESCRIPTION(DRIVER_DESC);
MODULE_LICENSE("GPL");

module_param(debug, bool, S_IWUSR | S_IRUGO);
MODULE_PARM_DESC(debug, "Debug enabled or not");
module_param(initial_mode, int, S_IRUGO);
MODULE_PARM_DESC(initial_mode, "Initial mode");

0 comments on commit ba74b89

Please sign in to comment.