Skip to content

Commit

Permalink
staging: line6: drop tuner param filtering
Browse files Browse the repository at this point in the history
The pod_set_system_param_int() helper function is only used to set the
monitor level.  Previously it was also used to control the tuner and has
special checks.  These checks can now be dropped, along with the tuner
constants.

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Stefan Hajnoczi authored and Greg Kroah-Hartman committed Nov 27, 2012
1 parent e620252 commit baa081f
Showing 1 changed file with 0 additions and 21 deletions.
21 changes: 0 additions & 21 deletions drivers/staging/line6/pod.c
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@ enum {

enum {
POD_monitor_level = 0x04,
POD_tuner_mute = 0x13,
POD_tuner_freq = 0x15,
POD_tuner_note = 0x16,
POD_tuner_pitch = 0x17,
POD_system_invalid = 0x10000
};

Expand Down Expand Up @@ -297,32 +293,15 @@ void line6_pod_transmit_parameter(struct usb_line6_pod *pod, int param,
line6_invalidate_current(&pod->dumpreq);
}

/*
Identify system parameters related to the tuner.
*/
static bool pod_is_tuner(int code)
{
return
(code == POD_tuner_mute) ||
(code == POD_tuner_freq) ||
(code == POD_tuner_note) || (code == POD_tuner_pitch);
}

/*
Send system parameter (from integer).
@param tuner non-zero, if code refers to a tuner parameter
*/
static int pod_set_system_param_int(struct usb_line6_pod *pod, int value,
int code)
{
char *sysex;
static const int size = 5;

if (((pod->prog_data.control[POD_tuner] & 0x40) == 0)
&& pod_is_tuner(code))
return -EINVAL;

/* send value to tuner: */
sysex = pod_alloc_sysex_buffer(pod, POD_SYSEX_SYSTEM, size);
if (!sysex)
return -ENOMEM;
Expand Down

0 comments on commit baa081f

Please sign in to comment.