Skip to content

Commit

Permalink
irqchip: gic: fix irq_trigger return
Browse files Browse the repository at this point in the history
The genirq layer expects a 0 in case that the retrigger function is
not able to resend the irq in hardware, but the code is returning
-ENXIO. Fix it.

[ tglx: Reworked comment and changelog ]

Signed-off-by: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-arm-kernel@lists.infradead.org
Link: http://lkml.kernel.org/r/1363734349-32635-1-git-send-email-sboyd@codeaurora.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Abhijeet Dharmapurikar authored and Thomas Gleixner committed Mar 26, 2013
1 parent c4052ba commit bad9a43
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/irqchip/irq-gic.c
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,8 @@ static int gic_retrigger(struct irq_data *d)
if (gic_arch_extn.irq_retrigger)
return gic_arch_extn.irq_retrigger(d);

return -ENXIO;
/* the genirq layer expects 0 if we can't retrigger in hardware */
return 0;
}

#ifdef CONFIG_SMP
Expand Down

0 comments on commit bad9a43

Please sign in to comment.