Skip to content

Commit

Permalink
batman-adv: Prefix send local static functions with batadv_
Browse files Browse the repository at this point in the history
All non-static symbols of batman-adv were prefixed with batadv_ to avoid
collisions with other symbols of the kernel. Other symbols of batman-adv
should use the same prefix to keep the naming scheme consistent.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
  • Loading branch information
Sven Eckelmann authored and Antonio Quartulli committed Jun 25, 2012
1 parent 63b0103 commit bb079c8
Showing 1 changed file with 15 additions and 15 deletions.
30 changes: 15 additions & 15 deletions net/batman-adv/send.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
#include "gateway_common.h"
#include "originator.h"

static void send_outstanding_bcast_packet(struct work_struct *work);
static void batadv_send_outstanding_bcast_packet(struct work_struct *work);

/* send out an already prepared packet to the given address via the
* specified batman interface
Expand Down Expand Up @@ -96,7 +96,7 @@ void batadv_schedule_bat_ogm(struct hard_iface *hard_iface)
bat_priv->bat_algo_ops->bat_ogm_schedule(hard_iface);
}

static void forw_packet_free(struct forw_packet *forw_packet)
static void batadv_forw_packet_free(struct forw_packet *forw_packet)
{
if (forw_packet->skb)
kfree_skb(forw_packet->skb);
Expand All @@ -105,9 +105,9 @@ static void forw_packet_free(struct forw_packet *forw_packet)
kfree(forw_packet);
}

static void _add_bcast_packet_to_list(struct bat_priv *bat_priv,
struct forw_packet *forw_packet,
unsigned long send_time)
static void _batadv_add_bcast_packet_to_list(struct bat_priv *bat_priv,
struct forw_packet *forw_packet,
unsigned long send_time)
{
INIT_HLIST_NODE(&forw_packet->list);

Expand All @@ -118,7 +118,7 @@ static void _add_bcast_packet_to_list(struct bat_priv *bat_priv,

/* start timer for this packet */
INIT_DELAYED_WORK(&forw_packet->delayed_work,
send_outstanding_bcast_packet);
batadv_send_outstanding_bcast_packet);
queue_delayed_work(batadv_event_workqueue, &forw_packet->delayed_work,
send_time);
}
Expand Down Expand Up @@ -171,7 +171,7 @@ int batadv_add_bcast_packet_to_list(struct bat_priv *bat_priv,
/* how often did we send the bcast packet ? */
forw_packet->num_packets = 0;

_add_bcast_packet_to_list(bat_priv, forw_packet, delay);
_batadv_add_bcast_packet_to_list(bat_priv, forw_packet, delay);
return NETDEV_TX_OK;

packet_free:
Expand All @@ -184,7 +184,7 @@ int batadv_add_bcast_packet_to_list(struct bat_priv *bat_priv,
return NETDEV_TX_BUSY;
}

static void send_outstanding_bcast_packet(struct work_struct *work)
static void batadv_send_outstanding_bcast_packet(struct work_struct *work)
{
struct hard_iface *hard_iface;
struct delayed_work *delayed_work =
Expand Down Expand Up @@ -220,13 +220,13 @@ static void send_outstanding_bcast_packet(struct work_struct *work)

/* if we still have some more bcasts to send */
if (forw_packet->num_packets < 3) {
_add_bcast_packet_to_list(bat_priv, forw_packet,
msecs_to_jiffies(5));
_batadv_add_bcast_packet_to_list(bat_priv, forw_packet,
msecs_to_jiffies(5));
return;
}

out:
forw_packet_free(forw_packet);
batadv_forw_packet_free(forw_packet);
atomic_inc(&bat_priv->bcast_queue_left);
}

Expand Down Expand Up @@ -260,7 +260,7 @@ void batadv_send_outstanding_bat_ogm_packet(struct work_struct *work)
if (!forw_packet->own)
atomic_inc(&bat_priv->batman_queue_left);

forw_packet_free(forw_packet);
batadv_forw_packet_free(forw_packet);
}

void batadv_purge_outstanding_packets(struct bat_priv *bat_priv,
Expand Down Expand Up @@ -292,15 +292,15 @@ void batadv_purge_outstanding_packets(struct bat_priv *bat_priv,

spin_unlock_bh(&bat_priv->forw_bcast_list_lock);

/* send_outstanding_bcast_packet() will lock the list to
/* batadv_send_outstanding_bcast_packet() will lock the list to
* delete the item from the list
*/
pending = cancel_delayed_work_sync(&forw_packet->delayed_work);
spin_lock_bh(&bat_priv->forw_bcast_list_lock);

if (pending) {
hlist_del(&forw_packet->list);
forw_packet_free(forw_packet);
batadv_forw_packet_free(forw_packet);
}
}
spin_unlock_bh(&bat_priv->forw_bcast_list_lock);
Expand All @@ -327,7 +327,7 @@ void batadv_purge_outstanding_packets(struct bat_priv *bat_priv,

if (pending) {
hlist_del(&forw_packet->list);
forw_packet_free(forw_packet);
batadv_forw_packet_free(forw_packet);
}
}
spin_unlock_bh(&bat_priv->forw_bat_list_lock);
Expand Down

0 comments on commit bb079c8

Please sign in to comment.