Skip to content

Commit

Permalink
target: Return correct ASC for unimplemented VPD pages
Browse files Browse the repository at this point in the history
My draft of SPC-4 says:

    If the device server does not implement the requested vital product
    data page, then the command shall be terminated with CHECK CONDITION
    status, with the sense key set to ILLEGAL REQUEST, and the
    additional sense code set to INVALID FIELD IN CDB.

Signed-off-by: Roland Dreier <roland@purestorage.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
  • Loading branch information
Roland Dreier authored and Nicholas Bellinger committed Jan 18, 2012
1 parent 2f9bc89 commit bb1acb2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/target/target_core_cdb.c
Original file line number Diff line number Diff line change
Expand Up @@ -729,7 +729,7 @@ int target_emulate_inquiry(struct se_task *task)
}

pr_err("Unknown VPD Code: 0x%02x\n", cdb[2]);
cmd->scsi_sense_reason = TCM_UNSUPPORTED_SCSI_OPCODE;
cmd->scsi_sense_reason = TCM_INVALID_CDB_FIELD;
ret = -EINVAL;

out_unmap:
Expand Down

0 comments on commit bb1acb2

Please sign in to comment.