Skip to content

Commit

Permalink
[IPV4]: Possible leak of multicast source filter sctructure
Browse files Browse the repository at this point in the history
There is a leak of a socket's multicast source filter list structure
on closing a socket with a multicast source filter set on an interface
that does not exist any more.

Signed-off-by: Michal Ruzicka <michal.ruzicka@comstar.cz>
Acked-by: David L Stevens <dlstevens@us.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Michal Ruzicka authored and David S. Miller committed Aug 17, 2006
1 parent 640c41c commit bb699cb
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions net/ipv4/igmp.c
Original file line number Diff line number Diff line change
Expand Up @@ -2199,13 +2199,13 @@ void ip_mc_drop_socket(struct sock *sk)
struct in_device *in_dev;
inet->mc_list = iml->next;

if ((in_dev = inetdev_by_index(iml->multi.imr_ifindex)) != NULL) {
(void) ip_mc_leave_src(sk, iml, in_dev);
in_dev = inetdev_by_index(iml->multi.imr_ifindex);
(void) ip_mc_leave_src(sk, iml, in_dev);
if (in_dev != NULL) {
ip_mc_dec_group(in_dev, iml->multi.imr_multiaddr.s_addr);
in_dev_put(in_dev);
}
sock_kfree_s(sk, iml, sizeof(*iml));

}
rtnl_unlock();
}
Expand Down

0 comments on commit bb699cb

Please sign in to comment.