Skip to content

Commit

Permalink
mfd: tps65010: Remove incorrect __exit markups
Browse files Browse the repository at this point in the history
Even if bus is not hot-pluggable, the devices can be unbound from the
driver via sysfs, so we should not be using __exit annotations on
remove() methods. The only exception is drivers registered with
platform_driver_probe() which specifically disables sysfs bind/unbind
attributes.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
  • Loading branch information
Dmitry Torokhov authored and Lee Jones committed Apr 9, 2015
1 parent 8d2f1a9 commit bb73370
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/mfd/tps65010.c
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ static int tps65010_gpio_get(struct gpio_chip *chip, unsigned offset)

static struct tps65010 *the_tps;

static int __exit tps65010_remove(struct i2c_client *client)
static int tps65010_remove(struct i2c_client *client)
{
struct tps65010 *tps = i2c_get_clientdata(client);
struct tps65010_board *board = dev_get_platdata(&client->dev);
Expand Down Expand Up @@ -684,7 +684,7 @@ static struct i2c_driver tps65010_driver = {
.name = "tps65010",
},
.probe = tps65010_probe,
.remove = __exit_p(tps65010_remove),
.remove = tps65010_remove,
.id_table = tps65010_id,
};

Expand Down

0 comments on commit bb73370

Please sign in to comment.