Skip to content

Commit

Permalink
[media] vivid: fix CROP_BOUNDS typo for video output
Browse files Browse the repository at this point in the history
An error was returned if composing was not supported, instead of if
cropping was not supported.

A classic copy-and-paste bug. Found with v4l2-compliance.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Cc: <stable@vger.kernel.org>      # for v3.18
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
  • Loading branch information
Hans Verkuil authored and Mauro Carvalho Chehab committed Dec 17, 2014
1 parent 5fdb967 commit bb9ff07
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/media/platform/vivid/vivid-vid-out.c
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ int vivid_vid_out_g_selection(struct file *file, void *priv,
sel->r = dev->fmt_out_rect;
break;
case V4L2_SEL_TGT_CROP_BOUNDS:
if (!dev->has_compose_out)
if (!dev->has_crop_out)
return -EINVAL;
sel->r = vivid_max_rect;
break;
Expand Down

0 comments on commit bb9ff07

Please sign in to comment.