Skip to content

Commit

Permalink
[PATCH] convert hugetlbfs_counter to atomic
Browse files Browse the repository at this point in the history
Implementation of hugetlbfs_counter() is functionally equivalent to
atomic_inc_return().  Use the simpler atomic form.

Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Chen, Kenneth W authored and Linus Torvalds committed Mar 22, 2006
1 parent 42b88be commit bba1e9b
Showing 1 changed file with 2 additions and 16 deletions.
18 changes: 2 additions & 16 deletions fs/hugetlbfs/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -737,21 +737,6 @@ static struct file_system_type hugetlbfs_fs_type = {

static struct vfsmount *hugetlbfs_vfsmount;

/*
* Return the next identifier for a shm file
*/
static unsigned long hugetlbfs_counter(void)
{
static DEFINE_SPINLOCK(lock);
static unsigned long counter;
unsigned long ret;

spin_lock(&lock);
ret = ++counter;
spin_unlock(&lock);
return ret;
}

static int can_do_hugetlb_shm(void)
{
return likely(capable(CAP_IPC_LOCK) ||
Expand All @@ -767,6 +752,7 @@ struct file *hugetlb_zero_setup(size_t size)
struct dentry *dentry, *root;
struct qstr quick_string;
char buf[16];
static atomic_t counter;

if (!can_do_hugetlb_shm())
return ERR_PTR(-EPERM);
Expand All @@ -775,7 +761,7 @@ struct file *hugetlb_zero_setup(size_t size)
return ERR_PTR(-ENOMEM);

root = hugetlbfs_vfsmount->mnt_root;
snprintf(buf, 16, "%lu", hugetlbfs_counter());
snprintf(buf, 16, "%u", atomic_inc_return(&counter));
quick_string.name = buf;
quick_string.len = strlen(quick_string.name);
quick_string.hash = 0;
Expand Down

0 comments on commit bba1e9b

Please sign in to comment.