Skip to content

Commit

Permalink
[PATCH] ppc: Fix platform_notify functions marked __init
Browse files Browse the repository at this point in the history
While adding USB support to an MV64360 based board this week, I
discovered that all MV64x60 boards in the kernel have platform_notify
functions marked with __init. This causes an oops if a device is added
after boot.

The patch below removes the __init markers. I do not have all these
boards to test on, but the change seems very unlikely to break anything
else.

Signed-off-by: Adrian Cox <adrian@humboldt.co.uk>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Adrian Cox authored and Paul Mackerras committed Mar 17, 2006
1 parent 7e5b593 commit bbbe121
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion arch/ppc/platforms/cpci690.c
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ cpci690_fixup_mpsc_pdata(struct platform_device *pdev)
pdata->brg_clk_freq = cpci690_get_bus_freq();
}

static int __init
static int
cpci690_platform_notify(struct device *dev)
{
static struct {
Expand Down
2 changes: 1 addition & 1 deletion arch/ppc/platforms/ev64260.c
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ ev64260_fixup_mpsc_pdata(struct platform_device *pdev)
return;
}

static int __init
static int
ev64260_platform_notify(struct device *dev)
{
static struct {
Expand Down
2 changes: 1 addition & 1 deletion arch/ppc/platforms/ev64360.c
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ ev64360_fixup_eth_pdata(struct platform_device *pdev)
}
#endif

static int __init
static int
ev64360_platform_notify(struct device *dev)
{
static struct {
Expand Down
2 changes: 1 addition & 1 deletion arch/ppc/platforms/hdpu.c
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ static void __init hdpu_fixup_cpustate_pdata(struct platform_device *pd)
}
#endif

static int __init hdpu_platform_notify(struct device *dev)
static int hdpu_platform_notify(struct device *dev)
{
static struct {
char *bus_id;
Expand Down
2 changes: 1 addition & 1 deletion arch/ppc/platforms/katana.c
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ katana_fixup_mv64xxx_pdata(struct platform_device *pdev)
}
#endif

static int __init
static int
katana_platform_notify(struct device *dev)
{
static struct {
Expand Down
2 changes: 1 addition & 1 deletion arch/ppc/platforms/radstone_ppc7d.c
Original file line number Diff line number Diff line change
Expand Up @@ -709,7 +709,7 @@ ppc7d_fixup_i2c_pdata(struct platform_device *pdev)
}
#endif

static int __init ppc7d_platform_notify(struct device *dev)
static int ppc7d_platform_notify(struct device *dev)
{
static struct {
char *bus_id;
Expand Down

0 comments on commit bbbe121

Please sign in to comment.