Skip to content

Commit

Permalink
wl1271: Fix msleep() delay while waiting for completion
Browse files Browse the repository at this point in the history
After last transmission, the device goes to sleep earlier
than the configured dynamic power save timeout. If timeout
is set to 400ms, device enters into sleep mode at around
330ms since from last TX.

This patch removes the msleep(1), which causes the delay
after ELP wakeup. Replaced with udelay(10), the variation
is around 7-10ms.

Signed-off-by: Saravanan Dhanabal <ext-saravanan.dhanabal@nokia.com>
Reviewed-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Saravanan Dhanabal authored and John W. Linville committed Mar 31, 2010
1 parent c189955 commit bc0f03e
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion drivers/net/wireless/wl12xx/wl1271_cmd.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@
#include "wl1271_cmd.h"
#include "wl1271_event.h"

#define WL1271_CMD_POLL_COUNT 5

/*
* send command to firmware
*
Expand All @@ -52,6 +54,7 @@ int wl1271_cmd_send(struct wl1271 *wl, u16 id, void *buf, size_t len,
u32 intr;
int ret = 0;
u16 status;
u16 poll_count = 0;

cmd = buf;
cmd->id = cpu_to_le16(id);
Expand All @@ -73,7 +76,11 @@ int wl1271_cmd_send(struct wl1271 *wl, u16 id, void *buf, size_t len,
goto out;
}

msleep(1);
udelay(10);
poll_count++;
if (poll_count == WL1271_CMD_POLL_COUNT)
wl1271_info("cmd polling took over %d cycles",
poll_count);

intr = wl1271_read32(wl, ACX_REG_INTERRUPT_NO_CLEAR);
}
Expand Down

0 comments on commit bc0f03e

Please sign in to comment.