Skip to content

Commit

Permalink
xen: use default_idle
Browse files Browse the repository at this point in the history
We just need the idle loop to drop into safe_halt, which default_idle()
is perfectly capable of doing.  There's no need to duplicate it.

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
  • Loading branch information
Jeremy Fitzhardinge committed Nov 23, 2010
1 parent c2d0879 commit bc15fde
Showing 1 changed file with 5 additions and 15 deletions.
20 changes: 5 additions & 15 deletions arch/x86/xen/setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -250,20 +250,6 @@ char * __init xen_memory_setup(void)
return "Xen";
}

static void xen_idle(void)
{
local_irq_disable();

if (need_resched())
local_irq_enable();
else {
current_thread_info()->status &= ~TS_POLLING;
smp_mb__after_clear_bit();
safe_halt();
current_thread_info()->status |= TS_POLLING;
}
}

/*
* Set the bit indicating "nosegneg" library variants should be used.
* We only need to bother in pure 32-bit mode; compat 32-bit processes
Expand Down Expand Up @@ -360,7 +346,11 @@ void __init xen_arch_setup(void)
MAX_GUEST_CMDLINE > COMMAND_LINE_SIZE ?
COMMAND_LINE_SIZE : MAX_GUEST_CMDLINE);

pm_idle = xen_idle;
/* Set up idle, making sure it calls safe_halt() pvop */
#ifdef CONFIG_X86_32
boot_cpu_data.hlt_works_ok = 1;
#endif
pm_idle = default_idle;

fiddle_vdso();
}

0 comments on commit bc15fde

Please sign in to comment.