Skip to content

Commit

Permalink
OMAP3: l3: fix for "irq 10: nobody cared" message
Browse files Browse the repository at this point in the history
If an error occurs in the L3 on any other initiator than MPU,
the interrupt goes unhandled given that the 'base' register
was calculated with the initialized err_source value (which
coincidentally points to MPU) and not with the actual source
of the error.

Removed parenthesis that are not needed for the touched lines.

Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
  • Loading branch information
omar ramirez authored and Tony Lindgren committed Apr 26, 2011
1 parent 6ba5932 commit bc16b37
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions arch/arm/mach-omap2/omap_l3_smx.c
Original file line number Diff line number Diff line change
Expand Up @@ -196,11 +196,11 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3)
/* No timeout error for debug sources */
}

base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));

/* identify the error source */
for (err_source = 0; !(status & (1 << err_source)); err_source++)
;

base = l3->rt + *(omap3_l3_bases[int_type] + err_source);
error = omap3_l3_readll(base, L3_ERROR_LOG);

if (error) {
Expand Down

0 comments on commit bc16b37

Please sign in to comment.