Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 268871
b: refs/heads/master
c: 06709e9
h: refs/heads/master
i:
  268869: 03e3ec3
  268867: b3f9844
  268863: 5083226
v: v3
  • Loading branch information
Mark Einon authored and Greg Kroah-Hartman committed Oct 23, 2011
1 parent 1bf50f6 commit bc1a52e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 9 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 26d19bf60be3a41bbd6c31d89d13a9c5e8edef8b
refs/heads/master: 06709e962322eb565f1e5ce591df7efb3db07c1f
1 change: 0 additions & 1 deletion trunk/drivers/staging/et131x/README
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ driver as they did not build properly at the time.

TODO:
- Use of kmem_cache seems a bit unusual
- It's too late stopping the tx queue when there is no room for the current packet. The condition should be detected for the next packet.

Please send patches to:
Greg Kroah-Hartman <gregkh@suse.de>
Expand Down
13 changes: 6 additions & 7 deletions trunk/drivers/staging/et131x/et131x.c
Original file line number Diff line number Diff line change
Expand Up @@ -3448,9 +3448,7 @@ static int send_packet(struct sk_buff *skb, struct et131x_adapter *adapter)
int et131x_send_packets(struct sk_buff *skb, struct net_device *netdev)
{
int status = 0;
struct et131x_adapter *adapter = NULL;

adapter = netdev_priv(netdev);
struct et131x_adapter *adapter = netdev_priv(netdev);

/* Send these packets
*
Expand Down Expand Up @@ -5347,6 +5345,11 @@ static void et131x_multicast(struct net_device *netdev)
static int et131x_tx(struct sk_buff *skb, struct net_device *netdev)
{
int status = 0;
struct et131x_adapter *adapter = netdev_priv(netdev);

/* stop the queue if it's getting full */
if(adapter->tx_ring.used >= NUM_TCB - 1 && !netif_queue_stopped(netdev))
netif_stop_queue(netdev);

/* Save the timestamp for the TX timeout watchdog */
netdev->trans_start = jiffies;
Expand All @@ -5357,10 +5360,6 @@ static int et131x_tx(struct sk_buff *skb, struct net_device *netdev)
/* Check status and manage the netif queue if necessary */
if (status != 0) {
if (status == -ENOMEM) {
/* Put the queue to sleep until resources are
* available
*/
netif_stop_queue(netdev);
status = NETDEV_TX_BUSY;
} else {
status = NETDEV_TX_OK;
Expand Down

0 comments on commit bc1a52e

Please sign in to comment.