Skip to content

Commit

Permalink
power_supply: max17042: Use regmap_update_bits instead read and write
Browse files Browse the repository at this point in the history
Consolidate regmap_read() and regmap_write() into one
regmap_update_bits() call. This is more readable and safer because
regmap's mutex will prevent any concurrent access to modified registers
(the concurrent access could happen through max17042_init_chip() in
scheduled work).

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
  • Loading branch information
Krzysztof Kozlowski authored and Sebastian Reichel committed Feb 25, 2015
1 parent 52fa74e commit bc35268
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions drivers/power/max17042_battery.c
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,6 @@ static int max17042_init_chip(struct max17042_chip *chip)
{
struct regmap *map = chip->regmap;
int ret;
int val;

max17042_override_por_values(chip);
/* After Power up, the MAX17042 requires 500mS in order
Expand Down Expand Up @@ -572,8 +571,7 @@ static int max17042_init_chip(struct max17042_chip *chip)
max17042_load_new_capacity_params(chip);

/* Init complete, Clear the POR bit */
regmap_read(map, MAX17042_STATUS, &val);
regmap_write(map, MAX17042_STATUS, val & (~STATUS_POR_BIT));
regmap_update_bits(map, MAX17042_STATUS, STATUS_POR_BIT, 0x0);
return 0;
}

Expand Down Expand Up @@ -745,9 +743,9 @@ static int max17042_probe(struct i2c_client *client,
IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
chip->battery.name, chip);
if (!ret) {
regmap_read(chip->regmap, MAX17042_CONFIG, &val);
val |= CONFIG_ALRT_BIT_ENBL;
regmap_write(chip->regmap, MAX17042_CONFIG, val);
regmap_update_bits(chip->regmap, MAX17042_CONFIG,
CONFIG_ALRT_BIT_ENBL,
CONFIG_ALRT_BIT_ENBL);
max17042_set_soc_threshold(chip, 1);
} else {
client->irq = 0;
Expand Down

0 comments on commit bc35268

Please sign in to comment.