Skip to content

Commit

Permalink
osdblk: Adjust queue limits to lower device's limits
Browse files Browse the repository at this point in the history
call blk_queue_stack_limits() to copy queue limits from
the underline osd scsi_device. This is absolutely needed
because osdblk cannot sleep when allocating a lower-request and
therefore cannot be bouncing.

TODO: Dynamic changes of limits to the lower device queue
will not reflect in the upper driver

Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
  • Loading branch information
Boaz Harrosh committed Jun 24, 2009
1 parent 2a13877 commit bc47df0
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions drivers/block/osdblk.c
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@
#include <scsi/osd_initiator.h>
#include <scsi/osd_attributes.h>
#include <scsi/osd_sec.h>
#include <scsi/scsi_device.h>

#define DRV_NAME "osdblk"
#define PFX DRV_NAME ": "
Expand Down Expand Up @@ -437,6 +438,12 @@ static int osdblk_init_disk(struct osdblk_device *osdev)
return rc;
}

/* Set our limits to the lower device limits, because osdblk cannot
* sleep when allocating a lower-request and therefore cannot be
* bouncing.
*/
blk_queue_stack_limits(q, osd_request_queue(osdev->osd));

blk_queue_prep_rq(q, blk_queue_start_tag);
blk_queue_ordered(q, QUEUE_ORDERED_DRAIN_FLUSH, osdblk_prepare_flush);

Expand Down

0 comments on commit bc47df0

Please sign in to comment.