Skip to content

Commit

Permalink
staging: comedi: adv_pci1710: remove board attach noise
Browse files Browse the repository at this point in the history
Remove the kernel message noise during the attach of the board.
Use a simple/clean dev_info at the end of the attach.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Sep 12, 2012
1 parent b84a9ce commit bc4b4aa
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions drivers/staging/comedi/drivers/adv_pci1710.c
Original file line number Diff line number Diff line change
Expand Up @@ -1332,8 +1332,6 @@ static int pci1710_attach(struct comedi_device *dev,
int ret, subdev, n_subdevices;
unsigned int irq;

dev_info(dev->class_dev, DRV_NAME ": attach\n");

ret = alloc_private(dev, sizeof(*devpriv));
if (ret < 0)
return -ENOMEM;
Expand Down Expand Up @@ -1377,15 +1375,8 @@ static int pci1710_attach(struct comedi_device *dev,
if (request_irq(irq, interrupt_service_pci1710,
IRQF_SHARED, "Advantech PCI-1710",
dev)) {
dev_dbg(dev->class_dev,
"unable to allocate IRQ %d, DISABLING IT",
irq);
irq = 0; /* Can't use IRQ */
} else {
dev_dbg(dev->class_dev, "irq=%u", irq);
}
} else {
dev_dbg(dev->class_dev, "IRQ disabled");
}
} else {
irq = 0;
Expand Down Expand Up @@ -1480,6 +1471,9 @@ static int pci1710_attach(struct comedi_device *dev,

devpriv->valid = 1;

dev_info(dev->class_dev, "%s attached, irq %sabled\n",
dev->board_name, dev->irq ? "en" : "dis");

return 0;
}

Expand Down

0 comments on commit bc4b4aa

Please sign in to comment.