Skip to content

Commit

Permalink
[PATCH] NOHZ: Produce debug output instead of a BUG()
Browse files Browse the repository at this point in the history
The BUG_ON() in tick_nohz_stop_sched_tick() triggers on some boxen.
Remove the BUG_ON and print information about the pending softirq
to allow better debugging of the problem.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Thomas Gleixner authored and Linus Torvalds committed Feb 19, 2007
1 parent 6ba9b34 commit bc5393a
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion kernel/time/tick-sched.c
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,9 @@ void tick_nohz_stop_sched_tick(void)
goto end;

cpu = smp_processor_id();
BUG_ON(local_softirq_pending());
if (unlikely(local_softirq_pending()))
printk(KERN_ERR "NOHZ: local_softirq_pending %02x\n",
local_softirq_pending());

now = ktime_get();
/*
Expand Down

0 comments on commit bc5393a

Please sign in to comment.