Skip to content

Commit

Permalink
dynamic_debug: replace strcpy with strlcpy, in ddebug_setup_query()
Browse files Browse the repository at this point in the history
Replace strcpy with strlcpy, and add define for the size constant.

[jbaron@redhat.com: Use DDEBUG_STRING_SIZE for overflow check]
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Jason Baron <jbaron@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Jim Cromie authored and Greg Kroah-Hartman committed Jan 24, 2012
1 parent 74df138 commit bc757f6
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions lib/dynamic_debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -525,14 +525,16 @@ EXPORT_SYMBOL(__dynamic_netdev_dbg);

#endif

static __initdata char ddebug_setup_string[1024];
#define DDEBUG_STRING_SIZE 1024
static __initdata char ddebug_setup_string[DDEBUG_STRING_SIZE];

static __init int ddebug_setup_query(char *str)
{
if (strlen(str) >= 1024) {
if (strlen(str) >= DDEBUG_STRING_SIZE) {
pr_warn("ddebug boot param string too large\n");
return 0;
}
strcpy(ddebug_setup_string, str);
strlcpy(ddebug_setup_string, str, DDEBUG_STRING_SIZE);
return 1;
}

Expand Down

0 comments on commit bc757f6

Please sign in to comment.