Skip to content

Commit

Permalink
[PATCH] SELinux: convert sbsec semaphore to a mutex
Browse files Browse the repository at this point in the history
This patch converts the semaphore in the superblock security struct to a
mutex.  No locking changes or other code changes are done.

Signed-off-by: Eric Paris <eparis@redhat.com>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
Acked-by: James Morris <jmorris@namei.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Eric Paris authored and Linus Torvalds committed Sep 26, 2006
1 parent 2397074 commit bc7e982
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
7 changes: 3 additions & 4 deletions security/selinux/hooks.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
#include <net/ip.h> /* for sysctl_local_port_range[] */
#include <net/tcp.h> /* struct or_callable used in sock_rcv_skb */
#include <asm/uaccess.h>
#include <asm/semaphore.h>
#include <asm/ioctls.h>
#include <linux/bitops.h>
#include <linux/interrupt.h>
Expand Down Expand Up @@ -243,7 +242,7 @@ static int superblock_alloc_security(struct super_block *sb)
if (!sbsec)
return -ENOMEM;

init_MUTEX(&sbsec->sem);
mutex_init(&sbsec->lock);
INIT_LIST_HEAD(&sbsec->list);
INIT_LIST_HEAD(&sbsec->isec_head);
spin_lock_init(&sbsec->isec_lock);
Expand Down Expand Up @@ -595,7 +594,7 @@ static int superblock_doinit(struct super_block *sb, void *data)
struct inode *inode = root->d_inode;
int rc = 0;

down(&sbsec->sem);
mutex_lock(&sbsec->lock);
if (sbsec->initialized)
goto out;

Expand Down Expand Up @@ -690,7 +689,7 @@ static int superblock_doinit(struct super_block *sb, void *data)
}
spin_unlock(&sbsec->isec_lock);
out:
up(&sbsec->sem);
mutex_unlock(&sbsec->lock);
return rc;
}

Expand Down
2 changes: 1 addition & 1 deletion security/selinux/include/objsec.h
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ struct superblock_security_struct {
unsigned int behavior; /* labeling behavior */
unsigned char initialized; /* initialization flag */
unsigned char proc; /* proc fs */
struct semaphore sem;
struct mutex lock;
struct list_head isec_head;
spinlock_t isec_lock;
};
Expand Down

0 comments on commit bc7e982

Please sign in to comment.