Skip to content

Commit

Permalink
[PATCH] md: minor code rearrangement in bitmap_init_from_disk
Browse files Browse the repository at this point in the history
Signed-off-by: Neil Brown <neilb@cse.unsw.edu.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
NeilBrown authored and Linus Torvalds committed Jun 22, 2005
1 parent d80a138 commit bc7f77d
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions drivers/md/bitmap.c
Original file line number Diff line number Diff line change
Expand Up @@ -781,26 +781,26 @@ static int bitmap_init_from_disk(struct bitmap *bitmap)
"recovery\n", bmname(bitmap));

bytes = (chunks + 7) / 8;
num_pages = (bytes + PAGE_SIZE - 1) / PAGE_SIZE;

num_pages = (bytes + sizeof(bitmap_super_t) + PAGE_SIZE - 1) / PAGE_SIZE + 1;

if (i_size_read(file->f_mapping->host) < bytes + sizeof(bitmap_super_t)) {
printk(KERN_INFO "%s: bitmap file too short %lu < %lu\n",
bmname(bitmap),
(unsigned long) i_size_read(file->f_mapping->host),
bytes + sizeof(bitmap_super_t));
goto out;
}
num_pages++;

ret = -ENOMEM;

bitmap->filemap = kmalloc(sizeof(struct page *) * num_pages, GFP_KERNEL);
if (!bitmap->filemap) {
ret = -ENOMEM;
if (!bitmap->filemap)
goto out;
}

bitmap->filemap_attr = kmalloc(sizeof(long) * num_pages, GFP_KERNEL);
if (!bitmap->filemap_attr) {
ret = -ENOMEM;
if (!bitmap->filemap_attr)
goto out;
}

memset(bitmap->filemap_attr, 0, sizeof(long) * num_pages);

Expand Down

0 comments on commit bc7f77d

Please sign in to comment.