Skip to content

Commit

Permalink
irqchip: s3c24xx: add missing __init annotations
Browse files Browse the repository at this point in the history
The s3c24xx_init_intc and s3c2412_init_irq functions are only called
at init time, and they call functions already marked __init, so they
should be marked in the same way. This was reported as

WARNING: vmlinux.o(.text+0x19e0b4): Section mismatch in reference from the function s3c2412_init_irq() to the function .init.text:s3c24xx_init_intc.constprop.8()
The function s3c2412_init_irq() references
the function __init s3c24xx_init_intc.constprop.8().
This is often because s3c2412_init_irq lacks a __init
annotation or the annotation of s3c24xx_init_intc.constprop.8 is wrong.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Heiko Stuebner <heiko@sntech.de>
Cc: Kukjin Kim <kgene.kim@samsung.com>
  • Loading branch information
Arnd Bergmann committed Apr 29, 2013
1 parent 522ccdb commit bc8fd90
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/irqchip/irq-s3c24xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ static void s3c24xx_clear_intc(struct s3c_irq_intc *intc)
}
}

static struct s3c_irq_intc *s3c24xx_init_intc(struct device_node *np,
static struct s3c_irq_intc * __init s3c24xx_init_intc(struct device_node *np,
struct s3c_irq_data *irq_data,
struct s3c_irq_intc *parent,
unsigned long address)
Expand Down Expand Up @@ -794,7 +794,7 @@ static struct s3c_irq_data init_s3c2412subint[32] = {
{ .type = S3C_IRQTYPE_LEVEL, .parent_irq = 21 }, /* CF */
};

void s3c2412_init_irq(void)
void __init s3c2412_init_irq(void)
{
pr_info("S3C2412: IRQ Support\n");

Expand Down

0 comments on commit bc8fd90

Please sign in to comment.