Skip to content

Commit

Permalink
drm/omap: Use old_fb to synchronize between successive page flips
Browse files Browse the repository at this point in the history
omap_crtc->old_fb is used to check whether the previous page flip has completed
or not. However, it's never initialized to anything, so it's always NULL. This
results in the check to always succeed, and the page_flip to proceed.

Initialize old_fb to the fb that we intend to flip to through page_flip, and
therefore prevent a future page flip to proceed if the last one didn't
complete.

Signed-off-by: Archit Taneja <archit@ti.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
  • Loading branch information
Archit Taneja authored and Tomi Valkeinen committed Apr 15, 2014
1 parent 71b6667 commit bc905ac
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/omapdrm/omap_crtc.c
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ static int omap_crtc_page_flip_locked(struct drm_crtc *crtc,
}

omap_crtc->event = event;
primary->fb = fb;
omap_crtc->old_fb = primary->fb = fb;

/*
* Hold a reference temporarily until the crtc is updated
Expand Down

0 comments on commit bc905ac

Please sign in to comment.