Skip to content

Commit

Permalink
[ALSA] sound/isa/sb/sb_mixer.c double kfree
Browse files Browse the repository at this point in the history
Modules: SB drivers

snd_ctl_add() already does the free on error.

Coverity bug #957

Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Dave Jones authored and Jaroslav Kysela committed Mar 22, 2006
1 parent c27e8c5 commit bcc54f9
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions sound/isa/sb/sb_mixer.c
Original file line number Diff line number Diff line change
Expand Up @@ -453,10 +453,8 @@ int snd_sbmixer_add_ctl(struct snd_sb *chip, const char *name, int index, int ty
strlcpy(ctl->id.name, name, sizeof(ctl->id.name));
ctl->id.index = index;
ctl->private_value = value;
if ((err = snd_ctl_add(chip->card, ctl)) < 0) {
snd_ctl_free_one(ctl);
if ((err = snd_ctl_add(chip->card, ctl)) < 0)
return err;
}
return 0;
}

Expand Down

0 comments on commit bcc54f9

Please sign in to comment.