Skip to content

Commit

Permalink
V4L/DVB: drivers/media/dvb/frontends: remove duplicate structure fiel…
Browse files Browse the repository at this point in the history
…d initialization

The read_status field is initialized twice to the same value.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier I, s, fld;
position p0,p;
expression E;
@@

struct I s =@p0 { ... .fld@p = E, ...};

@s@
identifier I, s, r.fld;
position r.p0,p;
expression E;
@@

struct I s =@p0 { ... .fld@p = E, ...};

@script:python@
p0 << r.p0;
fld << r.fld;
ps << s.p;
pr << r.p;
@@

if int(ps[0].line)<int(pr[0].line) or int(ps[0].column)<int(pr[0].column):
  cocci.print_main(fld,p0)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Julia Lawall authored and Mauro Carvalho Chehab committed Aug 2, 2010
1 parent 4743319 commit bd0db8c
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/media/dvb/frontends/mb86a16.c
Original file line number Diff line number Diff line change
Expand Up @@ -1833,7 +1833,6 @@ static struct dvb_frontend_ops mb86a16_ops = {

.get_frontend_algo = mb86a16_frontend_algo,
.search = mb86a16_search,
.read_status = mb86a16_read_status,
.init = mb86a16_init,
.sleep = mb86a16_sleep,
.read_status = mb86a16_read_status,
Expand Down

0 comments on commit bd0db8c

Please sign in to comment.