Skip to content

Commit

Permalink
x86, boot: Exclude cmdline.c if you can't use it
Browse files Browse the repository at this point in the history
CONFIG_EARLY_PRINTK is the only feature that might use command line
parsing in the decompression stage.  If it is disabled then we can
exclude the related code to save space. This can result in an estimated
space savings of 2240 bytes from the compressed kernel image.

Signed-off-by: Joe Millenbach <jmillenbach@gmail.com>
Link: http://lkml.kernel.org/r/1342746282-28497-8-git-send-email-jmillenbach@gmail.com
Signed-off-by: Gokul Caushik <caushik1@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
  • Loading branch information
Gokul Caushik authored and H. Peter Anvin committed Jul 21, 2012
1 parent cec49df commit bd448d4
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
4 changes: 4 additions & 0 deletions arch/x86/boot/compressed/cmdline.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#include "misc.h"

#ifdef CONFIG_EARLY_PRINTK

static unsigned long fs;
static inline void set_fs(unsigned long seg)
{
Expand All @@ -19,3 +21,5 @@ int cmdline_find_option_bool(const char *option)
{
return __cmdline_find_option_bool(real_mode->hdr.cmd_line_ptr, option);
}

#endif
5 changes: 3 additions & 2 deletions arch/x86/boot/compressed/misc.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,18 +38,19 @@ static inline void debug_putstr(const char *s)

#endif

#ifdef CONFIG_EARLY_PRINTK

/* cmdline.c */
int cmdline_find_option(const char *option, char *buffer, int bufsize);
int cmdline_find_option_bool(const char *option);

/* early_serial_console.c */
#ifdef CONFIG_EARLY_PRINTK

extern int early_serial_base;
void console_init(void);

#else

/* early_serial_console.c */
static const int early_serial_base;
static inline void console_init(void)
{ }
Expand Down

0 comments on commit bd448d4

Please sign in to comment.