Skip to content

Commit

Permalink
[media] drivers/media/pci/ngene/ngene-core.c: fix error return code
Browse files Browse the repository at this point in the history
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Peter Senna Tschudin authored and Mauro Carvalho Chehab committed Nov 22, 2012
1 parent 216f393 commit bd6973e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/media/pci/ngene/ngene-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1691,7 +1691,8 @@ int __devinit ngene_probe(struct pci_dev *pci_dev,
dev->i2c_current_bus = -1;

/* Register DVB adapters and devices for both channels */
if (init_channels(dev) < 0)
stat = init_channels(dev);
if (stat < 0)
goto fail2;

return 0;
Expand Down

0 comments on commit bd6973e

Please sign in to comment.