Skip to content

Commit

Permalink
libertas: precedence bug
Browse files Browse the repository at this point in the history
Negate has precedence over comparison so the original test was always
false.  (Neither 0 nor 1 are equal to NL80211_IFTYPE_MONITOR).

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Dan Carpenter authored and John W. Linville committed Jul 26, 2010
1 parent 3be61a3 commit bd75eb8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/wireless/libertas/tx.c
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ void lbs_send_tx_feedback(struct lbs_private *priv, u32 try_count)
{
struct tx_radiotap_hdr *radiotap_hdr;

if (!priv->wdev->iftype == NL80211_IFTYPE_MONITOR ||
if (priv->wdev->iftype != NL80211_IFTYPE_MONITOR ||
priv->currenttxskb == NULL)
return;

Expand Down

0 comments on commit bd75eb8

Please sign in to comment.