Skip to content

Commit

Permalink
staging: comedi: ke_counter: factor out the "find pci device" code
Browse files Browse the repository at this point in the history
Factor the "find pci device" code out of the attach function.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Jul 19, 2012
1 parent f2a6490 commit bd8a9bc
Showing 1 changed file with 26 additions and 11 deletions.
37 changes: 26 additions & 11 deletions drivers/staging/comedi/drivers/ke_counter.c
Original file line number Diff line number Diff line change
Expand Up @@ -122,18 +122,12 @@ static int cnt_rinsn(struct comedi_device *dev,
return 1;
}

static int cnt_attach(struct comedi_device *dev, struct comedi_devconfig *it)
static struct pci_dev *cnt_find_pci_dev(struct comedi_device *dev,
struct comedi_devconfig *it)
{
struct comedi_subdevice *subdevice;
struct pci_dev *pci_device = NULL;
struct cnt_board_struct *board;
unsigned long io_base;
int error, i;

/* allocate device private structure */
error = alloc_private(dev, sizeof(struct cnt_device_private));
if (error < 0)
return error;
struct pci_dev *pci_device = NULL;
int i;

/* Probe the device to determine what device in the series it is. */
for_each_pci_dev(pci_device) {
Expand Down Expand Up @@ -166,14 +160,35 @@ static int cnt_attach(struct comedi_device *dev, struct comedi_devconfig *it)
printk(KERN_WARNING
"comedi%d: no supported board found! (req. bus/slot: %d/%d)\n",
dev->minor, it->options[0], it->options[1]);
return -EIO;
return NULL;

found:
printk(KERN_INFO
"comedi%d: found %s at PCI bus %d, slot %d\n", dev->minor,
board->name, pci_device->bus->number,
PCI_SLOT(pci_device->devfn));
return pci_device;
}

static int cnt_attach(struct comedi_device *dev, struct comedi_devconfig *it)
{
struct pci_dev *pci_device;
struct comedi_subdevice *subdevice;
struct cnt_board_struct *board;
unsigned long io_base;
int error;

/* allocate device private structure */
error = alloc_private(dev, sizeof(struct cnt_device_private));
if (error < 0)
return error;

pci_device = cnt_find_pci_dev(dev, it);
if (!pci_device)
return -EIO;
devpriv->pcidev = pci_device;
board = (struct cnt_board_struct *)dev->board_ptr;

dev->board_name = board->name;

/* enable PCI device and request regions */
Expand Down

0 comments on commit bd8a9bc

Please sign in to comment.