Skip to content

Commit

Permalink
lockdep: fix compilation when CONFIG_TRACE_IRQFLAGS_SUPPORT is not set
Browse files Browse the repository at this point in the history
This patch fixes compilation if CONFIG_TRACE_IRQFLAGS_SUPPORT is ever
disabled (which is currently not allowed by Kconfig). Alternatively
we could just remove the option altogether and the associated code
paths. Since the compilation error has been in the tree for at
least two years and no one noticed it, I guess we don't really have
the need for CONFIG_TRACE_IRQFLAGS_SUPPORT=n.

Boot tested on x86 UP.

Signed-off-by: Rui Sousa <rui.p.m.sousa@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Rui Sousa authored and Ingo Molnar committed Sep 4, 2008
1 parent d210baf commit bd8fbde
Showing 1 changed file with 8 additions and 10 deletions.
18 changes: 8 additions & 10 deletions include/linux/irqflags.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,10 @@
# define start_critical_timings() do { } while (0)
#endif

#ifdef CONFIG_TRACE_IRQFLAGS_SUPPORT

#include <asm/irqflags.h>

#ifdef CONFIG_TRACE_IRQFLAGS_SUPPORT

#define local_irq_enable() \
do { trace_hardirqs_on(); raw_local_irq_enable(); } while (0)
#define local_irq_disable() \
Expand Down Expand Up @@ -84,21 +84,20 @@
* The local_irq_*() APIs are equal to the raw_local_irq*()
* if !TRACE_IRQFLAGS.
*/
# define raw_local_irq_disable() local_irq_disable()
# define raw_local_irq_enable() local_irq_enable()
# define raw_local_irq_save(flags) \
#define local_irq_disable() raw_local_irq_disable()
#define local_irq_enable() raw_local_irq_enable()
#define local_irq_save(flags) \
do { \
typecheck(unsigned long, flags); \
local_irq_save(flags); \
raw_local_irq_save(flags); \
} while (0)
# define raw_local_irq_restore(flags) \
# define local_irq_restore(flags) \
do { \
typecheck(unsigned long, flags); \
local_irq_restore(flags); \
raw_local_irq_restore(flags); \
} while (0)
#endif /* CONFIG_TRACE_IRQFLAGS_SUPPORT */

#ifdef CONFIG_TRACE_IRQFLAGS_SUPPORT
#define safe_halt() \
do { \
trace_hardirqs_on(); \
Expand All @@ -124,6 +123,5 @@
typecheck(unsigned long, flags); \
raw_irqs_disabled_flags(flags); \
})
#endif /* CONFIG_X86 */

#endif

0 comments on commit bd8fbde

Please sign in to comment.