Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 206835
b: refs/heads/master
c: ae94801
h: refs/heads/master
i:
  206833: a34962c
  206831: 43bbef6
v: v3
  • Loading branch information
Stefan Richter committed Jul 8, 2010
1 parent 283ed20 commit bda9ca9
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 9 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 3b2b65d68fc87b02ac393a031a4ebb3de84a8218
refs/heads/master: ae948011071c12ff6a328348859c717ea885ed40
15 changes: 7 additions & 8 deletions trunk/drivers/firewire/core-card.c
Original file line number Diff line number Diff line change
Expand Up @@ -239,17 +239,16 @@ static void fw_card_bm_work(struct work_struct *work)
struct fw_card *card = container_of(work, struct fw_card, work.work);
struct fw_device *root_device;
struct fw_node *root_node;
unsigned long flags;
int root_id, new_root_id, irm_id, local_id;
int gap_count, generation, grace, rcode;
bool do_reset = false;
bool root_device_is_running;
bool root_device_is_cmc;

spin_lock_irqsave(&card->lock, flags);
spin_lock_irq(&card->lock);

if (card->local_node == NULL) {
spin_unlock_irqrestore(&card->lock, flags);
spin_unlock_irq(&card->lock);
goto out_put_card;
}

Expand Down Expand Up @@ -291,7 +290,7 @@ static void fw_card_bm_work(struct work_struct *work)
card->bm_transaction_data[0] = cpu_to_be32(0x3f);
card->bm_transaction_data[1] = cpu_to_be32(local_id);

spin_unlock_irqrestore(&card->lock, flags);
spin_unlock_irq(&card->lock);

rcode = fw_run_transaction(card, TCODE_LOCK_COMPARE_SWAP,
irm_id, generation, SCODE_100,
Expand Down Expand Up @@ -322,7 +321,7 @@ static void fw_card_bm_work(struct work_struct *work)
goto out;
}

spin_lock_irqsave(&card->lock, flags);
spin_lock_irq(&card->lock);

if (rcode != RCODE_COMPLETE) {
/*
Expand All @@ -341,7 +340,7 @@ static void fw_card_bm_work(struct work_struct *work)
* We weren't BM in the last generation, and the last
* bus reset is less than 125ms ago. Reschedule this job.
*/
spin_unlock_irqrestore(&card->lock, flags);
spin_unlock_irq(&card->lock);
fw_schedule_bm_work(card, DIV_ROUND_UP(HZ, 8));
goto out;
}
Expand All @@ -364,7 +363,7 @@ static void fw_card_bm_work(struct work_struct *work)
* If we haven't probed this device yet, bail out now
* and let's try again once that's done.
*/
spin_unlock_irqrestore(&card->lock, flags);
spin_unlock_irq(&card->lock);
goto out;
} else if (root_device_is_cmc) {
/*
Expand Down Expand Up @@ -402,7 +401,7 @@ static void fw_card_bm_work(struct work_struct *work)
(card->gap_count != gap_count || new_root_id != root_id))
do_reset = true;

spin_unlock_irqrestore(&card->lock, flags);
spin_unlock_irq(&card->lock);

if (do_reset) {
fw_notify("phy config: card %d, new root=%x, gap_count=%d\n",
Expand Down

0 comments on commit bda9ca9

Please sign in to comment.