Skip to content

Commit

Permalink
fs/notify/inotify: decrement user inotify count on close
Browse files Browse the repository at this point in the history
The per-user inotify_devs value is incremented each time a new file is
allocated, but never decremented. This led to inotify_init failing after a
limited number of calls.

Signed-off-by: Keith Packard <keithp@keithp.com>
Signed-off-by: Eric Paris <eparis@redhat.com>
  • Loading branch information
Keith Packard authored and Eric Paris committed Jul 2, 2009
1 parent d960eea commit bdae997
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions fs/notify/inotify/inotify_user.c
Original file line number Diff line number Diff line change
Expand Up @@ -296,12 +296,15 @@ static int inotify_fasync(int fd, struct file *file, int on)
static int inotify_release(struct inode *ignored, struct file *file)
{
struct fsnotify_group *group = file->private_data;
struct user_struct *user = group->inotify_data.user;

fsnotify_clear_marks_by_group(group);

/* free this group, matching get was inotify_init->fsnotify_obtain_group */
fsnotify_put_group(group);

atomic_dec(&user->inotify_devs);

return 0;
}

Expand Down

0 comments on commit bdae997

Please sign in to comment.