---

yaml
---
r: 157917
b: refs/heads/master
c: eedbdf0
h: refs/heads/master
i:
  157915: 502e1c6
v: v3

[refs]

@@ -1,2 +1,2 @@
 ---
-refs/heads/master: b8e1c73f4608b8b9ca1e8f1a09f9fd8684e78071
+refs/heads/master: eedbdf03a25ab3b2c332ad7fa205aa8ffbe477ba

trunk/sound/usb/usbmixer.c

@@ -470,6 +470,15 @@ static int mixer_vol_tlv(struct snd_kcontrol *kcontrol, int op_flag,
 	 */
 	scale[2] = (convert_signed_value(cval, cval->min) * 100) / 256;
 	scale[3] = (convert_signed_value(cval, cval->max) * 100) / 256;
+	if (scale[3] <= scale[2]) {
+		/* something is wrong; assume it's either from/to 0dB */
+		if (scale[2] < 0)
+			scale[3] = 0;
+		else if (scale[2] > 0)
+			scale[2] = 0;
+		else /* totally crap, return an error */
+			return -EINVAL;
+	}
 	if (copy_to_user(_tlv, scale, sizeof(scale)))
 		return -EFAULT;
 	return 0;