Skip to content

Commit

Permalink
Merge branch 'pci/bjorn-remove-fakephp' into next
Browse files Browse the repository at this point in the history
* pci/bjorn-remove-fakephp:
  PCI: Remove the fakephp driver
  • Loading branch information
Bjorn Helgaas committed Sep 6, 2012
2 parents 7bf79d8 + c2b5acc commit be017b2
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 222 deletions.
32 changes: 0 additions & 32 deletions Documentation/feature-removal-schedule.txt
Original file line number Diff line number Diff line change
Expand Up @@ -253,38 +253,6 @@ Who: Dave Jones <davej@redhat.com>, Matthew Garrett <mjg@redhat.com>

-----------------------------

What: fakephp and associated sysfs files in /sys/bus/pci/slots/
When: 2011
Why: In 2.6.27, the semantics of /sys/bus/pci/slots was redefined to
represent a machine's physical PCI slots. The change in semantics
had userspace implications, as the hotplug core no longer allowed
drivers to create multiple sysfs files per physical slot (required
for multi-function devices, e.g.). fakephp was seen as a developer's
tool only, and its interface changed. Too late, we learned that
there were some users of the fakephp interface.

In 2.6.30, the original fakephp interface was restored. At the same
time, the PCI core gained the ability that fakephp provided, namely
function-level hot-remove and hot-add.

Since the PCI core now provides the same functionality, exposed in:

/sys/bus/pci/rescan
/sys/bus/pci/devices/.../remove
/sys/bus/pci/devices/.../rescan

there is no functional reason to maintain fakephp as well.

We will keep the existing module so that 'modprobe fakephp' will
present the old /sys/bus/pci/slots/... interface for compatibility,
but users are urged to migrate their applications to the API above.

After a reasonable transition period, we will remove the legacy
fakephp interface.
Who: Alex Chiang <achiang@hp.com>

---------------------------

What: CONFIG_RFKILL_INPUT
When: 2.6.33
Why: Should be implemented in userspace, policy daemon.
Expand Down
24 changes: 1 addition & 23 deletions drivers/pci/hotplug/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -17,28 +17,6 @@ menuconfig HOTPLUG_PCI

if HOTPLUG_PCI

config HOTPLUG_PCI_FAKE
tristate "Fake PCI Hotplug driver"
help
Say Y here if you want to use the fake PCI hotplug driver. It can
be used to simulate PCI hotplug events if even if your system is
not PCI hotplug capable.

This driver will "emulate" removing PCI devices from the system.
If the "power" file is written to with "0" then the specified PCI
device will be completely removed from the kernel.

WARNING, this does NOT turn off the power to the PCI device.
This is a "logical" removal, not a physical or electrical
removal.

Use this module at your own risk. You have been warned!

To compile this driver as a module, choose M here: the
module will be called fakephp.

When in doubt, say N.

config HOTPLUG_PCI_COMPAQ
tristate "Compaq PCI Hotplug driver"
depends on X86 && PCI_BIOS
Expand Down Expand Up @@ -143,7 +121,7 @@ config HOTPLUG_PCI_SHPC

config HOTPLUG_PCI_RPA
tristate "RPA PCI Hotplug driver"
depends on PPC_PSERIES && EEH && !HOTPLUG_PCI_FAKE
depends on PPC_PSERIES && EEH
help
Say Y here if you have a RPA system that supports PCI Hotplug.

Expand Down
3 changes: 0 additions & 3 deletions drivers/pci/hotplug/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@ obj-$(CONFIG_HOTPLUG_PCI_ACPI) += acpiphp.o

obj-$(CONFIG_HOTPLUG_PCI_ACPI_IBM) += acpiphp_ibm.o

# Link this last so it doesn't claim devices that have a real hotplug driver
obj-$(CONFIG_HOTPLUG_PCI_FAKE) += fakephp.o

pci_hotplug-objs := pci_hotplug_core.o pcihp_slot.o

ifdef CONFIG_HOTPLUG_PCI_CPCI
Expand Down
164 changes: 0 additions & 164 deletions drivers/pci/hotplug/fakephp.c

This file was deleted.

0 comments on commit be017b2

Please sign in to comment.