Skip to content

Commit

Permalink
drm/i915: Don't set PIN_MAPPABLE for legacy ringbuffers
Browse files Browse the repository at this point in the history
Tighter code since legacy gem has only mappable anyway.

Split out from Chris vma-bind rework.

Note that this is only possible due to the split-up of the mappable
pin flag into PIN_GLOBAL and PIN_MAPPABLE.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ben Widawsky <benjamin.widawsky@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Daniel Vetter committed Feb 14, 2014
1 parent a9cc726 commit be1fa12
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/i915/intel_ringbuffer.c
Original file line number Diff line number Diff line change
Expand Up @@ -1920,7 +1920,7 @@ int intel_init_render_ring_buffer(struct drm_device *dev)
return -ENOMEM;
}

ret = i915_gem_obj_ggtt_pin(obj, 0, PIN_MAPPABLE);
ret = i915_gem_obj_ggtt_pin(obj, 0, 0);
if (ret != 0) {
drm_gem_object_unreference(&obj->base);
DRM_ERROR("Failed to ping batch bo\n");
Expand Down

0 comments on commit be1fa12

Please sign in to comment.