Skip to content

Commit

Permalink
[media] drxk: Proper handle/propagate the error codes
Browse files Browse the repository at this point in the history
This driver is very big and complex. An error happening in the middle
of any initialization may cause the frontend to not work. So, it
needs to properly propagate error codes internally and to userspace.

Also, printing the error codes at the places it happened helps to
discover were's a bug at the code.

Before this change, a do { } while (0) loop and lots of breaks inside
were used to propagate errors. While this works, if there are
loops inside other loops, it could be easy to forget to add another
break, causing the error to not abort the function.

Also, as not all functions were reporting errors, it is hard to
discover why something failed.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Mauro Carvalho Chehab committed Jul 27, 2011
1 parent f1fe1b7 commit be44eb2
Showing 1 changed file with 3,573 additions and 3,592 deletions.
Loading

0 comments on commit be44eb2

Please sign in to comment.