Skip to content

Commit

Permalink
dccp: Bug in initial acknowledgment number assignment
Browse files Browse the repository at this point in the history
Step 8.5 in RFC 4340 says for the newly cloned socket

           Initialize S.GAR := S.ISS,

but what in fact the code (minisocks.c) does is

           Initialize S.GAR := S.ISR,

which is wrong (typo?) -- fixed by the patch.

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
  • Loading branch information
Gerrit Renker committed Jun 11, 2008
1 parent 7deb0f8 commit be4c798
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions net/dccp/minisocks.c
Original file line number Diff line number Diff line change
Expand Up @@ -165,12 +165,12 @@ struct sock *dccp_create_openreq_child(struct sock *sk,
/* See dccp_v4_conn_request */
newdmsk->dccpms_sequence_window = req->rcv_wnd;

newdp->dccps_gar = newdp->dccps_isr = dreq->dreq_isr;
dccp_update_gsr(newsk, dreq->dreq_isr);

newdp->dccps_iss = dreq->dreq_iss;
newdp->dccps_gar = newdp->dccps_iss = dreq->dreq_iss;
dccp_update_gss(newsk, dreq->dreq_iss);

newdp->dccps_isr = dreq->dreq_isr;
dccp_update_gsr(newsk, dreq->dreq_isr);

/*
* SWL and AWL are initially adjusted so that they are not less than
* the initial Sequence Numbers received and sent, respectively:
Expand Down

0 comments on commit be4c798

Please sign in to comment.