Skip to content

Commit

Permalink
target: Remove __transport_execute_tasks() for each processing context
Browse files Browse the repository at this point in the history
This patch removes the original usage of __transport_execute_tasks() ahead
of every transport_get_cmd_from_queue() call in transport_processing_thread().
This helps reduce se_device->execute_task_lock contention between qla2xxx wq
with target_submit_cmd() for READs and transport_processing_thread()
context servicing WRITEs with full payloads for I/O submission.

It also adds a __transport_execute_tasks() to kick the task queue again
without a *se_cmd descriptor with existing queue full logic, but this may
end up not being necessary.

Cc: Christoph Hellwig <hch@lst.de>
Cc: Roland Dreier <roland@purestorage.com>
Cc: Joern Engel <joern@logfs.org>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
  • Loading branch information
Nicholas Bellinger committed Dec 14, 2011
1 parent 4d2300c commit beb55a0
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/target/target_core_transport.c
Original file line number Diff line number Diff line change
Expand Up @@ -4655,8 +4655,6 @@ static int transport_processing_thread(void *param)
goto out;

get_cmd:
__transport_execute_tasks(dev, NULL);

cmd = transport_get_cmd_from_queue(&dev->dev_queue_obj);
if (!cmd)
continue;
Expand Down

0 comments on commit beb55a0

Please sign in to comment.